Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document caching in kfp v2 #3705

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Document caching in kfp v2 #3705

merged 1 commit into from
Apr 3, 2024

Conversation

geier
Copy link
Contributor

@geier geier commented Mar 28, 2024

No description provided.

@google-oss-prow Google OSS Prow
Copy link

Hi @geier. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot requested review from alfsuse and joeliedtke March 28, 2024 15:44
@geier
Document caching in kfp v2
cff579a 
Signed-off-by: Christian Geier <[email protected]>
@geier geier force-pushed the feature/kfpv2_caching branch from 32fa60a to cff579a Compare March 28, 2024 15:46
@geier
Copy link
Contributor Author

geier commented Mar 28, 2024

Pinging @rimolive as discussed

Only change is this (new) page: https://deploy-preview-3705--competent-brattain-de2d6d.netlify.app/docs/components/pipelines/v2/caching/

@rimolive
Copy link
Member

Thank you for your contribution, @geier !

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 28, 2024
Arhell
Arhell reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@rimolive
Copy link
Member

/assign @Tomcli @chensun @zijianjoy

Tomcli
Tomcli approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rimolive
Copy link
Member

rimolive commented Apr 1, 2024

/assign @chensun

chensun
chensun approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, geier, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8462a08 into kubeflow:master Apr 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@Tomcli Tomcli Tomcli approved these changes

@chensun chensun chensun approved these changes

@alfsuse alfsuse Awaiting requested review from alfsuse

@joeliedtke joeliedtke Awaiting requested review from joeliedtke

Assignees

@rimolive rimolive

@chensun chensun

@Tomcli Tomcli

@zijianjoy zijianjoy

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geier @rimolive @chensun @Tomcli @Arhell @zijianjoy